Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devices Management] Refactor some code to improve testability #7043

Closed
mnaturel opened this issue Sep 6, 2022 · 0 comments · Fixed by #7044
Closed

[Devices Management] Refactor some code to improve testability #7043

mnaturel opened this issue Sep 6, 2022 · 0 comments · Fixed by #7044
Assignees
Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Sep 6, 2022

Your use case

What would you like to do?

We should create a new clean copy of the existing “DevicesViewModel” into the V2 package. We should encapsultate all domain layer inside testable small UseCases.

Why would you like to do it?

To improve test coverage. And to ease readability of the code.

How would you like to achieve it?

  • ViewModel is clean and tested
  • All introduced use cases are tested
  • ViewState and other model classes are in their own class

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes

@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Settings labels Sep 6, 2022
@mnaturel mnaturel self-assigned this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant