Skip to content

fixed invites count badge bottom margin on a home screen #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fedrunov merged 1 commit into from
Aug 29, 2022
Merged

fixed invites count badge bottom margin on a home screen #6948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6947.wip
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[App Layout] fixed invites count badge bottom margin on a home screen
14 changes: 12 additions & 2 deletions vector/src/main/res/layout/item_invites_count.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="36sp"
android:background="?vctr_toolbar_background"
Copy link

@ElementBot ElementBot Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)
  • ⚠️ Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)

android:clickable="true"
android:focusable="true"

tools:viewBindingIgnore="true">

<im.vector.app.features.home.room.list.UnreadCounterBadgeView
Expand Down Expand Up @@ -45,4 +44,15 @@
app:layout_constraintEnd_toStartOf="@id/invites_count_badge"
app:layout_constraintTop_toTopOf="parent" />

<View
android:id="@+id/invites_divider"
android:layout_width="0dp"
android:layout_height="1dp"
android:layout_marginStart="22dp"
android:layout_marginEnd="16dp"
android:background="?vctr_list_separator_system"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />

</androidx.constraintlayout.widget.ConstraintLayout>