Skip to content

Conversation

@fedrunov
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

With recents carousel enabled, the Invites text button looks very close to the carousel

Motivation and context

closes #6947

Screenshots / GIFs

Screenshot 2022-08-26 at 14 54 03

@fedrunov fedrunov requested a review from ericdecanini August 26, 2022 12:55
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="36sp"
android:background="?vctr_toolbar_background"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)
  • ⚠️ Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fedrunov fedrunov merged commit 84d938d into develop Aug 29, 2022
@fedrunov fedrunov deleted the bugfix/nfe/app_layout_invites_count_margin branch August 29, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Layout: Invites badge has wrong bottom margin

4 participants