Skip to content

Space Switching: Adds Toolbar Click To Open Space Settings #6868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericdecanini merged 3 commits into from
Aug 23, 2022
Merged

Space Switching: Adds Toolbar Click To Open Space Settings #6868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c47c82
Adds click action to toolbar to open space settings
ericdecanini Aug 17, 2022
003a254
Adds changelog file
ericdecanini Aug 17, 2022
2a1483f
Merge remote-tracking branch 'origin/develop' into feature/eric/space…
ericdecanini Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6859.wip
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[New Layout] Adds space settings accessible through clicking the toolbar
9 changes: 9 additions & 0 deletions vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,20 @@ class NewHomeDetailFragment @Inject constructor(
}
}

views.collapsingToolbar.debouncedClicks(::openSpaceSettings)
views.toolbar.debouncedClicks(::openSpaceSettings)

views.avatar.debouncedClicks {
navigator.openSettings(requireContext())
}
}

private fun openSpaceSettings() = withState(viewModel) { viewState ->
viewState.selectedSpace?.let {
sharedActionViewModel.post(HomeActivitySharedAction.ShowSpaceSettings(it.roomId))
}
}

private fun setupBottomNavigationView() {
views.bottomNavigationView.menu.findItem(R.id.bottom_action_notification).isVisible = vectorPreferences.labAddNotificationTab()
views.bottomNavigationView.setOnItemSelectedListener {
Expand Down