Skip to content

Conversation

@ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Aug 17, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds a click action to the toolbar in the new app layout to open space settings

Motivation and context

Closes #6859

This functionality is present in the old app layout but wasn't yet present in the new layout.

We need to add the click listener on both the collapsing toolbar and the toolbar to have an effective click area of the whole toolbar. Adding a click listener on AppBarLayout doesn't work.

Screenshots / GIFs

image

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini added the PR-Small PR with less than 20 updated lines label Aug 17, 2022
@ericdecanini ericdecanini marked this pull request as ready for review August 17, 2022 20:31
@ericdecanini ericdecanini requested review from a team, fedrunov and yostyle and removed request for a team August 17, 2022 20:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
55.6% 55.6% Duplication

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericdecanini ericdecanini requested review from a team and removed request for a team and yostyle August 23, 2022 07:58
@ericdecanini ericdecanini merged commit 2830664 into develop Aug 23, 2022
@ericdecanini ericdecanini deleted the feature/eric/space-settings branch August 23, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Small PR with less than 20 updated lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space Switching: Access "Explore Spaces" and Space Settings

3 participants