Fix HTML entities being displayed in messages

[cloudrac3r]

Type of change

• Bugfix

Content

HTML entities are now displayed as the characters they represent.

Motivation and context

Fixes #6445. This was a regression from #6357.

Tests

My test case was an event with "formatted_body": "​ ♫ We're on easy street ♫". If successful, when displayed in Element Android, it should look like "♫ We're on easy street ♫".

I also looked at the tests I used in #6357.

Screenshots

{
  "body": "raw",
  "formatted_body": "​ ♫ We're on easy street ♫",
   "msgtype": "m.text",
   "format": "org.matrix.custom.html"
}

BEFORE	AFTER

Tested devices

• Physical, LineageOS 18.1 (Android 11)

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• N/A - UI change has been tested on both light and dark themes
• N/A - Accessibility has been taken into account
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• N/A - Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• N/A - If you have modified the screen flow, or added new screens to the application

Signed-off-by: Cadence Ember [email protected]

EDIT: @ouchadam - Added before/after screenshots

[ouchadam]

💯 thanks for the quick fix and adding some comments

I'll look into creating a test to capture regressions like this

[MyIgel]

Shouldn't there be some regression tests that cover this change?

[cloudrac3r]

Could be good. I didn't realise my original change would have as wide impacts as it did.

Fortunately, all issues around this seem to be fixed now.