Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters rendered as html tags in 1.4.26 #6445

Closed
bbhtt opened this issue Jul 3, 2022 · 5 comments · Fixed by #6447
Closed

Characters rendered as html tags in 1.4.26 #6445

bbhtt opened this issue Jul 3, 2022 · 5 comments · Fixed by #6447
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bbhtt
Copy link

bbhtt commented Jul 3, 2022

Steps to reproduce

Happens markdown enabled and disabled both

  1. Reply to a message having a word with quotation marks or find a message with the characters below.
  2. See that it's mangled.

Quotation marks:

image

Apostrophe and zero-width:

image

On web this looks like:

image

The event source for example:

{
  "content": {
    "body": "> <@...> test\n\n\"test\"",
    "format": "org.matrix.custom.html",
    "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!MJOXUSmcmyjOXEjsbp:.../$0VkvhRhLoDGyfXa86lX704YSw2DaOOSYA0jdUq7SdQo?via=...\">In reply to</a> <a href=\"https://matrix.to/#/@...\">@...</a><br />test</blockquote></mx-reply>&quot;test&quot;",
    "msgtype": "m.text"
  },
  "room_id": "!MJOXUSmcmyjOXEjsbp:...",
  "type": "m.room.message"
}
{
  "content": {
    "body": "​ ♫ We're on easy street ♫",
    "format": "org.matrix.custom.html",
    "formatted_body": "&ZeroWidthSpace; ♫ We&apos;re on easy street ♫",
    "msgtype": "m.text"
  },
  "event_id": "$165681828423000brNSu:matrix.org",
  "origin_server_ts": 1656818284642,
  "sender": "@_snoonet_gonzobot:matrix.org",
  "type": "m.room.message",
  "unsigned": {},
  "room_id": "!czDHgTFPrQVLaaYqbk:matrix.org"
}

Outcome

What did you expect?

Rendered properly.

What happened instead?

Rendered as html tags

Your phone model

No response

Operating system version

Andorid 10

Application version and app store

1.4.26 Google Play

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@bbhtt bbhtt added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 3, 2022
@bbhtt
Copy link
Author

bbhtt commented Jul 3, 2022

Probably a regression from #6357

@bbhtt bbhtt changed the title Quotation marks are rendered as &quot in 1.4.26 Characters rendered as html tags in 1.4.26 Jul 3, 2022
@cloudrac3r
Copy link
Contributor

Correct, this is a regression from 6537. I figured out how to fix it, expect a PR.

cloudrac3r added a commit to cloudrac3r/element-android that referenced this issue Jul 3, 2022
Initially reported in element-hq#6445. Fixes element-hq#6445.
This was a regression from element-hq#6357.

The fix is to enable Markwon's HTML entities processor.
SpiritCroc pushed a commit to SchildiChat/SchildiChat-android that referenced this issue Jul 10, 2022
Initially reported in element-hq#6445. Fixes element-hq#6445.
This was a regression from element-hq#6357.

The fix is to enable Markwon's HTML entities processor.

Change-Id: I65588d6df24257851490161f4672f7461e6e5fc1
SpiritCroc pushed a commit to SchildiChat/SchildiChat-android that referenced this issue Jul 10, 2022
Initially reported in element-hq#6445. Fixes element-hq#6445.
This was a regression from element-hq#6357.

The fix is to enable Markwon's HTML entities processor.

Change-Id: I65588d6df24257851490161f4672f7461e6e5fc1
@ouchadam
Copy link
Contributor

Fixed in v1.4.28

@dreaddr
Copy link

dreaddr commented Jul 12, 2022

When is that release expected?

@proletarius101
Copy link

When is that release expected?

You can also download the signed apks: https://github.com/vector-im/element-android/releases/tag/v1.4.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants