Skip to content

Conversation

@jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes #6147 , depends on #6134 .

Variable config outbound_keys_pre_sharing_mode in .well-known configuration of home server will be honoured now, overriding the default value of BuildConfig.outboundSessionKeySharingStrategy.

Motivation and context

See content ^.

Tests

  • Set up a home server.
  • Add this custom config to the synapse/rest/well_known.py configuration:
"io.element.e2ee": {
  "outbound_keys_pre_sharing_mode": "on_typing" # (or any of on_room_opening, on_typing, disabled)
}
  • Create an account in that home server.
  • Create or join a room, then do the interaction needed to pre-share the keys (just opening it, typing, etc.).

Tested devices

  • Physical
  • Emulator
  • OS version(s): 12

Checklist

@jmartinesp jmartinesp requested review from a team, mnaturel and yostyle and removed request for a team May 25, 2022 13:13
@jmartinesp jmartinesp force-pushed the feature/jorgem/outbound_presharing_keys_mode branch 2 times, most recently from 185f2f1 to cb729a4 Compare May 25, 2022 14:31
@github-actions
Copy link

github-actions bot commented May 25, 2022

Unit Test Results

146 files  ±0  146 suites  ±0   2m 50s ⏱️ +18s
236 tests ±0  236 ✔️ ±0  0 💤 ±0  0 ±0 
788 runs  ±0  788 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2271df9. ± Comparison against base commit 2e1a11e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Clear cache feature doesn't seem affected by this update

@jmartinesp jmartinesp force-pushed the feature/jorgem/outbound_presharing_keys_mode branch from cb729a4 to 2271df9 Compare May 31, 2022 09:33
@jmartinesp jmartinesp requested review from a team and ericdecanini and removed request for a team and mnaturel May 31, 2022 12:18
Copy link
Contributor

@ericdecanini ericdecanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmartinesp jmartinesp merged commit 166d2a3 into develop Jun 3, 2022
@jmartinesp jmartinesp deleted the feature/jorgem/outbound_presharing_keys_mode branch June 3, 2022 13:34
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=20 failures=2 errors=0 skipped=1
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow .well-known configuration to override key sharing mode

4 participants