Skip to content

Conversation

@jmartinesp
Copy link
Member

Fixes #6133 .

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds a feature to setup mandatory key backup or passphrase for all users based on the .well-known configuration of the home server.

Tests

  • Set up a server with the following configuration changes:
"io.element.e2ee": {
  "secure_backup_required": true
  "secure_backup_setup_methods": ["passphrase"] (optional, defaults to "all methods accepted")
}
  • Create an account in it.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 12.

Checklist

@jmartinesp jmartinesp self-assigned this May 24, 2022
@jmartinesp jmartinesp requested review from a team, fedrunov and yostyle and removed request for a team May 24, 2022 07:51
@github-actions
Copy link

github-actions bot commented May 24, 2022

Unit Test Results

142 files  ±0  142 suites  ±0   2m 32s ⏱️ +2s
229 tests ±0  229 ✔️ ±0  0 💤 ±0  0 ±0 
760 runs  ±0  760 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 130ed63. ± Comparison against base commit 483b1ab.

♻️ This comment has been updated with latest results.

@jmartinesp jmartinesp force-pushed the feature/jorgem/mandatory-backup-passphrase branch from 9b9d0d2 to e1f9e4d Compare May 24, 2022 09:52
@jmartinesp
Copy link
Member Author

It seems like I missed some code needed to make verification also mandatory if this config is used, it's included now.

@jmartinesp jmartinesp requested a review from yostyle May 25, 2022 08:43
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for changes

@jmartinesp jmartinesp force-pushed the feature/jorgem/mandatory-backup-passphrase branch from cad07bd to 130ed63 Compare May 31, 2022 08:01
@jmartinesp jmartinesp enabled auto-merge May 31, 2022 08:03
@jmartinesp jmartinesp disabled auto-merge May 31, 2022 08:10
@jmartinesp jmartinesp enabled auto-merge May 31, 2022 08:20
@jmartinesp jmartinesp merged commit 2e1a11e into develop May 31, 2022
@jmartinesp jmartinesp deleted the feature/jorgem/mandatory-backup-passphrase branch May 31, 2022 09:02
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=27 failures=1 errors=0 skipped=1
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for mandatory backup/passphrase from .well-known configuration

4 participants