Fix an error in string resource (#4997)

[bmarty]

Fixes #4997

[github-actions]

Unit Test Results

  68 files  ±0    68 suites  ±0   47s ⏱️ -7s
136 tests ±0  136 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
420 runs  ±0  420 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 953f34f. ± Comparison against base commit 491044b.

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  passed="21" failures="0" errors="0" skipped="2"
• [org.matrix.android.sdk.account]
  passed="5" failures="0" errors="0" skipped="2"
• [org.matrix.android.sdk.internal]
  passed="158" failures="12" errors="0" skipped="38"
• [org.matrix.android.sdk.ordering]
  passed="16" failures="0" errors="0" skipped="0"
• [org.matrix.android.sdk.PermalinkParserTest]
  passed="2" failures="0" errors="0" skipped="0"

[ouchadam]

I'm a little confused by the issue of using zero, does weblate not support unique plurals per locale?

[onurays]

Surprised and lgtm!

[bmarty]

I'm a little confused by the issue of using zero, does weblate not support unique plurals per locale?

Using zero for English language is not correct, see https://developer.android.com/guide/topics/resources/string-resource#Plurals:

In English, a string for zero is ignored even if the quantity is 0, because 0 isn't grammatically different from 2, or any other number except 1 ("zero books", "one book", "two books", and so on)

On some other language, zero can have specific plural form. So If we want to special case zero in English (and so in all the languages), we have to do it manually like on this PR.

Other languages may need to define zero for the plural poll_total_vote_count_before_ended_and_not_voted to be correct regarding the plural form, but in the fact, this translation will never be used in that case.

[ouchadam]

💯 ahhh it's an empty case rather than 0 specific plural