Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing plurals in localization #4997

Closed
libexus opened this issue Jan 19, 2022 · 1 comment · Fixed by #4999
Closed

Missing plurals in localization #4997

libexus opened this issue Jan 19, 2022 · 1 comment · Fixed by #4999
Assignees
@bmarty
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@libexus
Copy link
Contributor

libexus commented Jan 19, 2022 •
edited
Loading

Steps to reproduce

poll_total_vote_count_before_ended_and_not_voted has 3 plural forms (0, 1, >1) in the source string, but the translated strings have not. This is not exclusive to german.

grafik

Outcome

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No
@libexus libexus added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 19, 2022
@bmarty
Copy link
Member

bmarty commented Jan 19, 2022

This is an error, <item quantity="zero"> should not be present in the default translation. I will fix that.

@bmarty bmarty self-assigned this Jan 19, 2022
bmarty added a commit that referenced this issue Jan 19, 2022
@bmarty
Fix an error in string resource (#4997)
953f34f
@bmarty bmarty mentioned this issue Jan 19, 2022
Merged
bmarty added a commit that referenced this issue Jan 20, 2022
@bmarty
Merge pull request #4999 from vector-im/feature/bma/zero_vote
c40fc52 
Fix an error in string resource (#4997)
onurays added a commit that referenced this issue Jan 23, 2022
@onurays
Merge branch 'develop' into feature/ons/edit_polls
7f97e78 
* develop: (66 commits)
  toolbar management  (#4887)
  adding changelog entry
  adding back periodic flag when scheduling automatic background workers
  Fix enum class warning
  Split long lines Done by matrix-org/matrix-analytics-events#16
  Add new class in analytics plan
  Fix conditional for Delight issue automation
  Add missing import in kdoc
  Update kdoc
  Enable Delight issue automation
  Fix an error in string resource (#4997)
  Changelog
  Add some unit test for the command parser. Not all commands are covered, could add more tests later.
  data class.
  use sealed interface
  Small cleanup
  Command parser is not a static object anymore
  Add changelog
  Use Throwable.isLimitExceededError extension
  Do not automatically retry 429 with a too long delay
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an error in string resource (#4997) element-hq/element-android
2 participants
@bmarty @libexus