Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4602.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
There is no need to call job.cancel() when we are using viewModelScope()
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,4 @@ class SearchViewModel @AssistedInject constructor(
)
}
}

override fun onCleared() {
currentTask?.cancel()
super.onCleared()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,4 @@ class RoomDirectoryViewModel @AssistedInject constructor(
}
}
}

override fun onCleared() {
currentJob?.cancel()
super.onCleared()
}
}