There is no need to call job.cancel() when we are using viewModelScope() #4603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Dec 1, 2021
|
|
||
| override fun onCleared() { | ||
| currentJob?.cancel() | ||
| super.onCleared() |
Member
There was a problem hiding this comment.
I think we can do more cleanup by removing the fun (at both places)
Contributor
There was a problem hiding this comment.
👍 for removing the field as well
Member
There was a problem hiding this comment.
the field is still useful I think
Contributor
Author
There was a problem hiding this comment.
Yes, override fun onCleared can be deleted. The field is used in another line
Contributor
There was a problem hiding this comment.
ah I see this directory viewmodel is also using it to dedupe the requests
if (currentJob == null) {
// load more
}
Member
There was a problem hiding this comment.
bmarty
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #4602