Social Login #2484
Merged
Social Login #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/social_login
branch
from
0cfc5af
to
e2c375e
Compare
|
@bmarty regarding the known server completion, can you please advise if i should move the HomeServerHistoryService somewhere else? and should i refactor RawModule and move global DB somewhere else? |
bmarty
requested changes
Dec 7, 2020
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/auth/data/IdentityProvider.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/auth/data/IdentityProvider.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/auth/data/IdentityProvider.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/data/LoginFlowResponse.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/data/LoginFlowResponse.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/signout/soft/SoftLogoutController.kt
Show resolved
Hide resolved
vector/src/main/res/layout/fragment_login_signup_signin_selection.xml
Outdated
Show resolved
Hide resolved
And new custom homeserver completion (and remember history)
bmarty
force-pushed
the
feature/bca/social_login
branch
from
ec4515a
to
0fd8641
Compare
bmarty
approved these changes
Dec 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2452
This PR is adding social logins buttons on signInSignup / Signin / SignUp screens.
This is possible thx to a change in loginFlow response, the sso type can now provide a list of identity providers that can be used to display dedicated button for each. This is still using fallback flows.
Application now supports both SSO and Password servers, previously if SSO was available the app would only let you use SSO.
Fixes #1933