Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Social login #2452

Closed
BillCarsonFr opened this issue Nov 26, 2020 · 2 comments · Fixed by #2484
Closed

[Android] Social login #2452

BillCarsonFr opened this issue Nov 26, 2020 · 2 comments · Fixed by #2484
Assignees
@BillCarsonFr
Labels
A-SSO
Milestone
Sprint 17

Comments

@BillCarsonFr
Copy link
Member

Implement matrix-org/matrix-spec-proposals#2858

#see matrix-org/matrix-react-sdk#5426

image
@BillCarsonFr BillCarsonFr changed the title Delight | Support Social Login flows Android | Support Social Login flows Nov 26, 2020
@niquewoodhouse
Copy link

@BillCarsonFr I think this layout might be better - as we could have an unknown number of them. Something to discuss with @nadonomy probably.

Screenshot 2020-11-27 at 10 54 31

@BillCarsonFr BillCarsonFr self-assigned this Nov 30, 2020
@BillCarsonFr
Copy link
Member Author

BillCarsonFr commented Nov 30, 2020 •
edited by bmarty
Loading

Just a remark that the buttons do not follow strict branding guidelines.
image

vs

image

Not sure how much of that is mandatory ...

EDIT Benoit: https://developers.google.com/identity/branding-guidelines

@nadonomy nadonomy changed the title Android | Support Social Login flows Social login Dec 1, 2020
@nadonomy nadonomy mentioned this issue Dec 1, 2020
Closed
@nadonomy nadonomy changed the title Social login [Android] Social login Dec 1, 2020
@BillCarsonFr BillCarsonFr mentioned this issue Dec 3, 2020
Merged
@bmarty bmarty added this to the Sprint 17 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-SSO
Projects
None yet
Milestone
Sprint 17
Development

Successfully merging a pull request may close this issue.

Social Login element-hq/element-android
3 participants
@niquewoodhouse @bmarty @BillCarsonFr