Skip to content

Remove closing animation of Menu component #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianduros merged 5 commits into from
Jan 23, 2026
Merged

Remove closing animation of Menu component #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a37702c
feat: add props to disable closing animation of `Menu`
florianduros Jan 23, 2026
40409d0
refactor: use `hasClosingAnimation=false` for `ContextMenu`
florianduros Jan 23, 2026
fb36399
test: update snapshot
florianduros Jan 23, 2026
64728c3
test(e2e): add screenshot
florianduros Jan 23, 2026
2d9651a
fix: remove closing animation of `Menu`
florianduros Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/components/Menu/ContextMenu.module.css
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/components/Menu/ContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { FloatingMenu } from "./FloatingMenu";
import { Drawer } from "vaul";
import classnames from "classnames";
import drawerStyles from "./DrawerMenu.module.css";
import contextStyles from "./ContextMenu.module.css";
import {
MenuContext,
type MenuData,
Expand Down Expand Up @@ -141,7 +140,7 @@ export const ContextMenu: FC<Props> = ({
<Root onOpenChange={onOpenChange}>
{trigger}
<Portal>
<Content asChild className={classnames(contextStyles.content)}>
<Content asChild>
<FloatingMenu showTitle={showTitle} title={title}>
{children}
</FloatingMenu>
Expand Down
11 changes: 0 additions & 11 deletions src/components/Menu/FloatingMenu.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,10 @@ Please see LICENSE files in the repository root for full details.
}
}

@keyframes slide-out {
to {
opacity: 0;
transform: translate(0, var(--cpd-space-2x));
}
}

.menu[data-state="open"] {
animation: slide-in 180ms;
}

.menu[data-state="closed"] {
animation: slide-out 110ms;
}

@keyframes fade-in {
from {
opacity: 0;
Expand Down
1 change: 1 addition & 0 deletions src/components/Menu/FloatingMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ interface Props extends ComponentPropsWithoutRef<"div"> {
export const FloatingMenu = forwardRef<HTMLDivElement, Props>(
({ title, showTitle = true, className, children, ...props }, ref) => {
const titleId = useId();

return (
<div
role="menu"
Expand Down
Loading