Remove closing animation of Menu component#432
Merged
florianduros merged 5 commits intomainfrom Jan 23, 2026
Merged
Conversation
The closing animation is launched when the menu is closed (looking at data-state="closed"). If we remove the menu trigger menu from the dom when the menu is closed, the animation is still ongoing and causes the menu to be positioned at 0,0.
Deploying compound-web with
|
| Latest commit: |
2d9651a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97c0a3d6.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-closing-animati.compound-web.pages.dev |
florianduros
force-pushed
the
florianduros/closing-animation-menu
branch
from
fb83e56 to
64728c3
Compare
florianduros
requested review from
dbkr and
t3chguy
and removed request for
a team
dbkr
approved these changes
Jan 23, 2026
Member
|
I feel like this yields an unpolished UX, either the closing animation should be entirely removed or fixed to work consistently rather than some menus animate and some do not. |
florianduros
force-pushed
the
florianduros/closing-animation-menu
branch
2 times, most recently
from
e27a67e to
f0dced8
Compare
Member
|
I'm also a little unsatisfied with entirely removing the closing animation, though can live with it if there isn't a better fix. Does anyone know if this has been reported upstream with Radix? |
Member
Author
|
@robintown the issue is not from radix but from us adding a closing animation when the radix component is closed |
florianduros
force-pushed
the
florianduros/closing-animation-menu
branch
from
f0dced8 to
ada0dae
Compare
florianduros
force-pushed
the
florianduros/closing-animation-menu
branch
from
ada0dae to
2d9651a
Compare
Member
|
PR title no longer matches content |
florianduros
changed the title
Menu component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closing animation is launched when the menu is closed (looking at data-state="closed"). If we remove the menu trigger menu from the dom when the menu is closed, the animation is still ongoing and causes the menu to be positioned at 0,0.
Needed to fix element-hq/element-web#31834