Set up CI #88
Merged
Set up CI #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically we need the sortByReference type fix from v3.8.0: https://github.com/amzn/style-dictionary/blob/e8aea2f68404a2c4841ee5eb55525e837f34e326/CHANGELOG.md#380-2023-04-25
jmartinesp
approved these changes
Jul 10, 2024
Comment on lines
+59
to
+70
| export const cpdFontBodyXsRegular = "400 0.688rem/1.5 Inter"; | ||
| export const cpdFontBodyXsMedium = "500 0.688rem/1.5 Inter"; | ||
| export const cpdFontBodyXsSemibold = "600 0.688rem/1.5 Inter"; | ||
| export const cpdFontBodySmRegular = "400 0.813rem/1.5 Inter"; | ||
| export const cpdFontBodySmMedium = "500 0.813rem/1.5 Inter"; | ||
| export const cpdFontBodySmSemibold = "600 0.813rem/1.5 Inter"; | ||
| export const cpdFontBodyMdRegular = "400 0.938rem/1.5 Inter"; | ||
| export const cpdFontBodyMdMedium = "500 0.938rem/1.5 Inter"; | ||
| export const cpdFontBodyMdSemibold = "600 0.938rem/1.5 Inter"; | ||
| export const cpdFontBodyLgRegular = "400 1.063rem/1.5 Inter"; | ||
| export const cpdFontBodyLgMedium = "500 1.063rem/1.5 Inter"; | ||
| export const cpdFontBodyLgSemibold = "600 1.063rem/1.5 Inter"; |
There was a problem hiding this comment.
These actually change the size, even if not by much. Is that ok?
There was a problem hiding this comment.
Oh, this should actually go into #87 😅
There was a problem hiding this comment.
Ah, I missed this before I merged the other PR. I'll try to research why Style Dictionary is rounding the values, and whether it messes with anything.
There was a problem hiding this comment.
(as in, I'll do that in another PR now that it's already too late…)
|
I changed the base to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start using GitHub Actions to check formatting/lints and ensure that all generated files are up to date.
Based on #87 - please only review the later commits