Lint and format with Biome #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks for improving the quality of the project! Maybe update the doc https://github.com/element-hq/compound-design-tokens/blob/main/docs/development.md to explain how to run the checks locally. It can be discovered by looking at the CI instructions at #88 but having an up to date documentation is always helpful. |
|
Very nice 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this project has no linter or formatter set up, but we could benefit from having one to help us avoid TypeScript's gotchas and not have to think about style choices too much. Normally, the tools of choice are Eslint and Prettier, but Prettier is a bit slow at its job, and Eslint invites a bit more fiddling with plugins than I'd like.
I've recently started using Biome for a personal project, and I like it a lot. It's fast and has a reasonable set of defaults, so I think it's well-suited for a project like this where we only need a lightweight solution to formatting and linting. I suggest we try it out!
Reviewable commit-by-commit.