fix: Drop build metadata part in convertVersion #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickymohk
changed the title
felixrieseberg
approved these changes
May 19, 2023
|
The code looks good to me, thank you! Quick ask: Could we add a test just to check that we're handling version numbers correctly? |
|
@felixrieseberg Added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume the purpose of
convertVersionis to convert the version string to semver 1.0 standard which Squirrel can support. So it might as well drop the build metadata part specified in semver 2.0, denoted by a+sign. Since by specification, the build metadata has no effect on precedence, I think it makes sense to simply discard it instead of incorporating it.