fix: Drop build metadata part in convertVersion (#472)

* Drop build metadata part in convertVersion * added test cases for convertVersion
electron · May 19, 2023 · 275176c · 275176c
1 parent 2def401
commit 275176c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/spec/convert-version-spec.ts b/spec/convert-version-spec.ts
@@ -9,4 +9,6 @@ test('makes semver versions into valid NuGet versions', (t): void => {
   t.is(convertVersion('1.2.3-alpha.1'), '1.2.3-alpha1');
   t.is(convertVersion('1.2.3-alpha.1.2'), '1.2.3-alpha12');
   t.is(convertVersion('1.2.3-alpha-1-2'), '1.2.3-alpha-1-2');
+  t.is(convertVersion('1.2.3-alpha.1.2+build-meta.1.2'), '1.2.3-alpha12');
+  t.is(convertVersion('1.2.3-alpha-1-2+build-meta.1.2'), '1.2.3-alpha-1-2');
 });
diff --git a/src/index.ts b/src/index.ts
@@ -12,7 +12,7 @@ export { SquirrelWindowsOptions as Options} from './options';
 const log = require('debug')('electron-windows-installer:main');
 
 export function convertVersion(version: string): string {
-  const parts = version.split('-');
+  const parts = version.split('+')[0].split('-');
   const mainVersion = parts.shift();
 
   if (parts.length > 0) {