Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary shim for Forge #1641

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: temporary shim for Forge #1641

merged 1 commit into from
Dec 19, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Dec 19, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Temporary fix for electron/forge#3443, this should be reverted once a new Forge version is released.

@erikian erikian requested a review from a team as a code owner December 19, 2023 13:59
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d829dbe) 92.03% compared to head (72cdeb3) 91.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   92.03%   91.80%   -0.24%     
==========================================
  Files          16       16              
  Lines         854      854              
  Branches      167      167              
==========================================
- Hits          786      784       -2     
- Misses         51       52       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erikian erikian marked this pull request as draft December 19, 2023 14:04
@erikian erikian force-pushed the fix/temp-forge-shim branch from 127df03 to be234e6 Compare December 19, 2023 14:08
@erikian erikian marked this pull request as ready for review December 19, 2023 14:08
@erikian erikian force-pushed the fix/temp-forge-shim branch from be234e6 to 72cdeb3 Compare December 19, 2023 14:28
@VerteDinde VerteDinde merged commit a810162 into main Dec 19, 2023
4 of 5 checks passed
@VerteDinde VerteDinde deleted the fix/temp-forge-shim branch December 19, 2023 15:08
Copy link

🎉 This PR is included in version 18.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants