Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: remove temporary shim #1698

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build!: remove temporary shim #1698

wants to merge 1 commit into from

Conversation

erikian
Copy link
Member

@erikian erikian commented Mar 28, 2024

This was added in #1641 to temporarily provide a missing file that Forge relied on until a new Forge version was released with an updated version of Packager, so we don't need this anymore.

@erikian erikian requested a review from a team as a code owner March 28, 2024 00:11
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (224cc6a) to head (58f9495).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1698   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          17       17           
  Lines         899      899           
  Branches      187      187           
=======================================
  Hits          801      801           
  Misses         61       61           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11
Copy link
Member

Isn't there still potential for issues here, if a user updates their version of @electron/packager without updating their version of Forge? Since Forge indicates it can use any minor version of v18 of @electron/packager, so someone on Forge v7.2.0 could still have a need for this.

It's probably an unlikely situation, but maybe we just leave the shim until the next breaking change in Packager?

@erikian
Copy link
Member Author

erikian commented Apr 2, 2024

Yeah good point, this can wait for the next major release, enough inadvertent breaking changes on v18 😂

@erikian erikian marked this pull request as draft April 2, 2024 10:47
@erikian erikian changed the title build: remove temporary shim build!: remove temporary shim Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants