Skip to content

build: add shim to gitignore #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

build: add shim to gitignore #1642

merged 1 commit into from
Dec 21, 2023

Conversation

dsanders11
Copy link
Member

Summarize your changes:

The shim introduced in #1641 causes an issue with the docs publish workflow since it is seen as an uncommitted file. Adding it to .gitignore fixes that.

@dsanders11 dsanders11 requested a review from erikian December 21, 2023 22:19
@dsanders11 dsanders11 requested a review from a team as a code owner December 21, 2023 22:19
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a810162) 92.03% compared to head (63a99d2) 91.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   92.03%   91.80%   -0.24%     
==========================================
  Files          16       16              
  Lines         854      854              
  Branches      167      167              
==========================================
- Hits          786      784       -2     
- Misses         51       52       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11 dsanders11 merged commit 27bd500 into main Dec 21, 2023
@dsanders11 dsanders11 deleted the gitignore-shim branch December 21, 2023 22:50
Copy link

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants