Skip to content

fix: strictVerify not working with true value #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlackHole1 merged 2 commits into from
Mar 5, 2025
Merged

fix: strictVerify not working with true value #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0833b37
Fix strictVerify not working with true value
t3chguy Feb 3, 2025
86a3b7f
Fix handling of `strictVerify=undefined`
t3chguy Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/sign.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,14 @@ async function verifySignApplication (opts: ValidatedSignOptions) {
// Verify with codesign
debugLog('Verifying application bundle with codesign...');

const strictVerify = opts.strictVerify !== undefined ? opts.strictVerify : true;
await execFileAsync(
'codesign',
['--verify', '--deep'].concat(
opts.strictVerify !== false && compareVersion(osRelease, '15.0.0') >= 0 // Strict flag since darwin 15.0.0 --> OS X 10.11.0 El Capitan
strictVerify !== false && compareVersion(osRelease, '15.0.0') >= 0 // Strict flag since darwin 15.0.0 --> OS X 10.11.0 El Capitan
? [
'--strict' +
(opts.strictVerify
? '=' + opts.strictVerify // Array should be converted to a comma separated string
: '')
(strictVerify !== true ? '=' + strictVerify : '')
]
: [],
['--verbose=2', opts.app]
Expand Down
3 changes: 2 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,11 @@ export type OnlySignOptions = {
provisioningProfile?: string;
/**
* Flag to enable/disable the `--strict` flag when verifying the signed application bundle.
* Also supports string values to specify which strict restrictions to use, see codesign man page for supported values.
*
* @defaultValue `true`
*/
strictVerify?: boolean;
strictVerify?: boolean | string;
/**
* Type of certificate to use when signing a MAS app.
* @defaultValue `"distribution"`
Expand Down