fix: strictVerify not working with true value#345
Merged
BlackHole1 merged 2 commits intoelectron:mainfrom Mar 5, 2025
Merged
Conversation
And extend it to support string-specified restrictions
Contributor
Author
|
What is left to do here? |
Member
|
@t3chguy Can you fix test unit? 🙇♂️ |
t3chguy
force-pushed
the
t3chguy/fix/344
branch
from
e92b1f6 to
86a3b7f
Compare
Member
|
Hey @t3chguy 👋. I noticed that @erickzhao has set himself as a reviewer, so I think we should wait for him to do the code review as well. However, he is currently on vacation, so we may have to wait until he returns next week. |
Contributor
Author
|
No rush from my end |
erickzhao
approved these changes
Mar 4, 2025
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And extend it to support string-specified restrictions
Fixes #344