feat(electron-updater): allow overriding AppUpdater.isStagingMatch#9021
Merged
mmaietta merged 1 commit intoelectron-userland:masterfrom Apr 11, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: f704bf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f3dd057 to
a08d213
Compare
Lemonexe
commented
Apr 10, 2025
mmaietta
reviewed
Apr 10, 2025
Collaborator
|
This is clean! Thank you for the contribution Quick request, can you generate a changeset file for this using |
Merged
a08d213 to
f704bf6
Compare
Contributor
Author
|
@mmaietta Done. I ran The last one generated a diff in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation for #9016
Add get/set/protected
isUserWithinRolloutinterface toAppUpdaterclass, similarly to how it is implemented forisUpdateSupportedso that you can override the default calculation of staging percentage.The user will be offerred an update if the other necessary conditions are met, but they would otherwise be below the rollout threshold.
Usecase
staging rollout is observed when automatically querying for updates in background, but we also have a manual "Check for updates" button in Settings. This will allow the manual check to always offer you the latest version.