fix(msi): build emulated arm64 MSI installers as stopgap until electron-builder-binaries wix version is updated #8086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3937e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Allan-Kerr
force-pushed
the
akerr/6077/dev
branch
from
81fe012 to
2b91b9a
Compare
mmaietta
reviewed
Feb 29, 2024
Build x64 MSI installers when targeting the arm64 architecture. This results in an x64 MSI installer that installs an arm64 version of the application. An x64 MSI installer is an improvement because building arm64 MSI targets errors with: ``` error CNDL0264 : The parameter 'arch' is missing or has an invalid value arm64. Possible values are x86, x64, or ia64. ``` This is a stopgap until the electron-builder-binaries wix version is upgraded to a version that supports arm64 which is currently blocked by a number of breaking changes between 4.0.0.5512.2 and 4.0.1. This upgrade is discussed in electron-userland#6077.
Allan-Kerr
force-pushed
the
akerr/6077/dev
branch
from
2b91b9a to
c3937e2
Compare
Merged
mmaietta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build x64 MSI installers when targeting the arm64 architecture. This results in an x64 MSI installer that installs an arm64 version of the application.
An x64 MSI installer is an improvement because building arm64 MSI targets errors with:
This is a stopgap until the electron-builder-binaries wix version is upgraded to a version that supports arm64 which is currently blocked by a number of breaking changes between 4.0.0.5512.2 and 4.0.1. This upgrade is discussed in #6077.