Replace resources library with okio and re-add web targets #21
Conversation
turf/src/commonTest/kotlin/io/github/elcolto/geokjson/turf/utils/FileSystem.kt
Outdated
Show resolved
Hide resolved
| import okio.FileSystem | ||
|
|
||
| actual val FILE_SYSTEM: FileSystem = FileSystem.SYSTEM |
There was a problem hiding this comment.
Regarding to the non-working ios/apple targets, I think we have to do it like here and change the path.
I can invastigate in the next days.
There was a problem hiding this comment.
Apparently, by now it somehow seems like the ios tests would run 🤔
Can you confirm on your system? I also used the fakeFileSystem, which allows execution of wasm targets now.
There was a problem hiding this comment.
actually not, when running the task allTests
also wasm tests don't work
There was a problem hiding this comment.
Further I look into finding a setup to read resources from every test target, I think it's more work when it helps 🙄
What about moving every json resource into a multiline string literal within the corresponding test. Or global values within Kotlin test directory?
I'll try to make a commit as a proposal
There was a problem hiding this comment.
yikes... there are big files... I may think this can lead to OOM errors sooner or later
There was a problem hiding this comment.
Do we want to close this PR in favor of #29. Since adding json data to kotlin files is not possible.
|
Closed PR, because JS target was added with #29 again. WASM target still to come |
Tests on ios may still fail, due to potential invalid path. We may have to take a look into that as soon as we decide whether we want to run the tests on all platforms.
The problem why the targets could not be added before was laying in the file-reading library that was used.
See goncalossilva/kotlinx-resources#101. As the issue has not been adressed yet, i swapped the library with okio. As okios wasm impl is not stable yet i left that one with a todo for now
Closes #4