[DOCS] OAuth authentication added to SN connectors #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastasha-solomon
requested review from
benironside,
cnasikas,
jmikell821,
joepeeples and
lcawl
and removed request for
cnasikas
15 tasks
joepeeples
reviewed
Jun 13, 2022
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
Added a few comments and suggestions. A few comments speak to issues that were preexisting before this PR to add OAuth, so maybe a little out of scope and fine if you'd rather postpone re-architecting some of the tables.
Co-authored-by: Joe Peeples <[email protected]>
benironside
reviewed
Jun 15, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Looks good! Left a few suggestions.
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: benironside <[email protected]>
Co-authored-by: benironside <[email protected]>
ymao1
reviewed
Jun 17, 2022
|
we have validated this and found all the required changes present ✔️
Hence we are adding "QA:Valdiated" to it . thanks !!! |
ghost
added
QA:Validated
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
…s into issue-2042-oauth-sn
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: benironside <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> (cherry picked from commit aeddc6b)
nastasha-solomon
added a commit
that referenced
this pull request
Jun 24, 2022
) (#2143) Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: benironside <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: nastasha-solomon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2042 and makes minor structural adjustments to steps that had bulleted sub-steps (changed bullets to table rows for a cleaner look).
Preview here.
NOTE: Main change was added docs for the Use OAuth authentication setting. At the moment, there's no way to link to the new sections that were added to the SN connector topics (anchors aren't there), so I linked to the main Connectors page instead. I can coordinate with @lcawl to add the anchors if needed.