Skip to content

[DOCS] Edits OAuth instructions in ServiceNow connector docs#134970

Merged
lcawl merged 5 commits intoelastic:mainfrom
lcawl:oauth
Jun 23, 2022
Merged

[DOCS] Edits OAuth instructions in ServiceNow connector docs#134970
lcawl merged 5 commits intoelastic:mainfrom
lcawl:oauth

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 23, 2022 •
edited
Loading

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes docs auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.3.1 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Jun 23, 2022
@lcawl lcawl marked this pull request as ready for review June 23, 2022 15:46
@lcawl lcawl requested review from a team as code owners June 23, 2022 15:46
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 23, 2022

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from nastasha-solomon June 23, 2022 15:46
nastasha-solomon
nastasha-solomon reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @lcawl, this looks really great! Thank you for inserting the anchors and for adding to the connector pre-reqs. That'll make it much easier for me to link to these sections from the Security docs. I also checked for non-rendered attributes and didn't find any. Everything looks good from my end - thanks!

@nastasha-solomon nastasha-solomon self-requested a review June 23, 2022 15:57
ymao1
ymao1 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit c676878 into elastic:main Jun 23, 2022
@lcawl lcawl deleted the oauth branch June 23, 2022 17:25
kibanamachine pushed a commit that referenced this pull request Jun 23, 2022
@lcawl
[DOCS] Edits OAuth instructions in ServiceNow connector docs (#134970)
c2c97b2 
(cherry picked from commit c676878)
@kibanamachine kibanamachine mentioned this pull request Jun 23, 2022
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 23, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 23, 2022
@kibanamachine @lcawl
[DOCS] Edits OAuth instructions in ServiceNow connector docs (#134970) (
7d22cf2 
#135064)

(cherry picked from commit c676878)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymao1 ymao1 ymao1 approved these changes

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.3.1 v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lcawl @elasticmachine @kibanamachine @ymao1 @nastasha-solomon