It enables the new multipart transfer manager inside track downloader.#1965
It enables the new multipart transfer manager inside track downloader.#1965fressi-elastic merged 154 commits intoelastic:masterfrom
Conversation
9b8b092 to
0f0fc44
Compare
Co-authored-by: Grzegorz Banasiak <grzegorz.banasiak@elastic.co>
BTW when boto3 is not available, storage client should fail registering S3Adapter and simply skip it. On such a case |
|
After last changes in the logging setup I got this results: |
… when `boto3` package is not installed.
gbanasiak
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your patience.
It allows to use the new multipart transfer manager for downloading track files.
Configuration documentation.
Adapterinterface.head->want.Clientclass.CachedHead`class to store cached heads.Client.headmethod raisesCachedHeadErrorto wrap errors that have been previously cached.Client.resolvemethod only logs errors that hasn't been obtaining from the cache (I.E. when capturing aCachedHeadError).Client.getrefactored to properly handle theresolvedhead filtering.Config
StorageConfigclass is now used to pack values parsed from theesrally.condig.Configobject and pass values through objects of the storage package. This is nice to reduce the effort of keeping distinction between user configured values and actual object variables. It also make easier to centralize configuration parsing and validation to one single place.Track loader
track.downloader.multipart_enabledconfiguration flag.Threads utils
intervalvalue when initializingContinuousTimerclass. The value is now public.Testing
Note this requited the following PRs to be merged first:
storagebranch. #1960TransferManagerandS3Adapterclasses. #1964