Skip to content

Update storage tools with last changes from storage branch.#1960

Merged
fressi-elastic merged 15 commits intoelastic:masterfrom
fressi-elastic:storage.transfer
Jul 22, 2025
Merged

Update storage tools with last changes from storage branch.#1960
fressi-elastic merged 15 commits intoelastic:masterfrom
fressi-elastic:storage.transfer

Conversation

@fressi-elastic
Copy link
Contributor

@fressi-elastic fressi-elastic commented Jul 16, 2025

This change introduces some improvements from this new feature development branch:

  • Head class is now a dataclass used to pass parameters between methods and to verify responses with the requested parameters.
  • It uses a generic match_url class method to maps URLS to adapter classes.
  • AdapterRegistry class skips non-existing modules.
  • It adds list and put methods to Adapter interface.
  • It adds MirrorList.from_config factory method.
  • It adds put method to Client class.
  • It adds a ThreadPoolExecutor subclass with its from_config factory method.
  • It makes the HTTPAdapter easier to extend.

@fressi-elastic fressi-elastic marked this pull request as ready for review July 16, 2025 15:51
@fressi-elastic fressi-elastic enabled auto-merge (squash) July 16, 2025 15:53
@fressi-elastic fressi-elastic requested review from a team and gbanasiak July 16, 2025 15:58
Copy link
Contributor

@favilo favilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. I've left some comments and questions

Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I left some questions to understand this change better.

Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fressi-elastic fressi-elastic merged commit cd469fb into elastic:master Jul 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants