Skip to content

Backport reminders - add missing default values#947

Merged
NickDris merged 1 commit intoelastic:masterfrom
NickDris:backport/fix-reminder
Dec 5, 2025
Merged

Backport reminders - add missing default values#947
NickDris merged 1 commit intoelastic:masterfrom
NickDris:backport/fix-reminder

Conversation

@NickDris
Copy link
Contributor

@NickDris NickDris commented Dec 5, 2025

After merging backport PR we noticed workflow failures because of missing values for --lookback-days and --pending-reminder-age-days. Also --pr-mode arg was incorrectly placed in the single PR case. This PR fixes them.

@NickDris NickDris requested a review from gbanasiak December 5, 2025 12:13
@NickDris NickDris changed the title Add missing default values for the basic arguments Backport reminders - add missing default values for the basic arguments Dec 5, 2025
@NickDris NickDris changed the title Backport reminders - add missing default values for the basic arguments Backport reminders - add missing default values Dec 5, 2025
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickDris NickDris merged commit 1d09b5c into elastic:master Dec 5, 2025
15 checks passed
@NickDris NickDris deleted the backport/fix-reminder branch December 5, 2025 14:31
@esbenchmachine esbenchmachine added the backport pending Awaiting backport to stable release branch label Dec 5, 2025
@esbenchmachine
Copy link
Collaborator

@NickDris
A backport is pending for this PR. Please add all required vX.Y version labels.

  • If it is intended for the current Elasticsearch release version, apply the corresponding version label.
  • If it also supports past released versions, add those labels too.
  • If it only targets a future version, wait until that version label exists and then add it.
    (Each rally-tracks version label is created during the feature freeze of a new Elasticsearch branch).

Backporting entails:

  1. Ensure the correct version labels exist in this PR.
  2. Ensure backport PRs have backport label and are passing tests.
  3. Merge backport PRs (you can approve yourself and enable auto-merge).
  4. Remove backport pending label from this PR once all backport PRs are merged.

Thank you!

@NickDris NickDris added the v9.2 label Dec 5, 2025
@esbenchmachine
Copy link
Collaborator

💔 All backports failed

Status Branch Result
9.2 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.2:
- CI determines Elasticsearch build arguments using unified job in gh workflow [stateful] (#925)
- Exclude some challenges when testing with ES release builds (#922)
- Reduce filtering scope in CI workflow (#908)
- Address pytest deprecations (#911)
- Fix pytest skip argument (#905)
- Solves problems with expensive inlinestats benchmarks (#896)
- Adds better challenges for comparing inlinestats (#873)
- Change backport labeling pattern to vX.Y

Manual backport

To create the backport manually run:

backport --pr 947

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@gbanasiak
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gbanasiak pushed a commit to gbanasiak/rally-tracks that referenced this pull request Dec 5, 2025
)

After merging backport PR we noticed workflow failures
because of missing values for --lookback-days
and --pending-reminder-age-days. Also --pr-mode arg
was incorrectly placed in the single PR case.

(cherry picked from commit 1d09b5c)

# Conflicts:
#	.github/workflows/backport.reminder.yml
gbanasiak pushed a commit to gbanasiak/rally-tracks that referenced this pull request Dec 8, 2025
)

After merging backport PR we noticed workflow failures 
because of missing values for --lookback-days 
and --pending-reminder-age-days. Also --pr-mode arg 
was incorrectly placed in the single PR case.
@NickDris NickDris added the v8.15 label Dec 9, 2025
NickDris added a commit that referenced this pull request Dec 9, 2025
)

After merging backport PR we noticed workflow failures
because of missing values for --lookback-days
and --pending-reminder-age-days. Also --pr-mode arg
was incorrectly placed in the single PR case.

(cherry picked from commit 1d09b5c)

# Conflicts:
#	.github/workflows/backport.reminder.yml

Co-authored-by: Nick Dris <nick.dris@elastic.co>
@NickDris NickDris removed the backport pending Awaiting backport to stable release branch label Dec 9, 2025
NickDris added a commit to NickDris/rally-tracks that referenced this pull request Dec 10, 2025
)

After merging backport PR we noticed workflow failures 
because of missing values for --lookback-days 
and --pending-reminder-age-days. Also --pr-mode arg 
was incorrectly placed in the single PR case.
NickDris added a commit that referenced this pull request Dec 12, 2025
After merging backport PR we noticed workflow failures 
because of missing values for --lookback-days 
and --pending-reminder-age-days. Also --pr-mode arg 
was incorrectly placed in the single PR case.
NickDris added a commit to NickDris/rally-tracks that referenced this pull request Dec 18, 2025
)

After merging backport PR we noticed workflow failures 
because of missing values for --lookback-days 
and --pending-reminder-age-days. Also --pr-mode arg 
was incorrectly placed in the single PR case.
NickDris added a commit that referenced this pull request Dec 20, 2025
* Tests tracks selectively based on PR changes (#858)
* CI builds ES revision from sources based on es-version file (#875)
* Drop Python 3.9 and introduce Python 3.13 in CI (#877)
* [ES-13188] Update GH macOS hosted runner image (#883)
* Address pytest deprecations (#911)
* CI determines Elasticsearch build arguments using unified job in gh workflow [stateful] (#925)
* Fix an error where ci arguments were not applied properly (#928)
* Fix an error where ci arguments were not applied properly
* Test the change
* Test failed retry with another fix
* Previous fix failed retry
* Revert es-version to current
* Keep the indents if if/else
* Add backport reminder and reorganize the backporting actions. (#889)
* Rename IT folders (#938)
* Fix pytest skip argument (#905)
* Backport reminders - fix missing default values in workflow (#947)
* Upgrade pip to 25.2
* Fix conflict in it_tracks
* Update deprecated gh actions
* Track changes for 8.19
* Fix test job which does not require the output of other jobs
* Add backport reminder and reorganize the backporting actions. (#889)
* Fix an error where ci arguments were not applied properly (#928)
* Reduce filtering scope in CI workflow (#908)
* Add pytest marker for cars
* Address merge conflicts
* Run serverless CI only on PRs targeting master (#859)
* Accept pragma risks for joins esql
* Make esql-full-text-functions a snapshot_only_challenge
* Set index template for ingest_mode: data_stream (#849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants