Adds better challenges for comparing inlinestats#873
Merged
ncordon merged 4 commits intoelastic:masterfrom Oct 28, 2025
Merged
Conversation
Contributor
|
@elasticmachine update branch |
gareth-ellis
approved these changes
Oct 13, 2025
Member
gareth-ellis
left a comment
gareth-ellis
left a comment
There was a problem hiding this comment.
LGTM - remember that once this is merged the nightly benchmark charts will need updating (there seems to be inline related graphs there
esbenchmachine
added
the
backport pending
gbanasiak
pushed a commit
that referenced
this pull request
Nov 19, 2025
Contributor
|
backported to |
gbanasiak
added
v9.2
and removed
backport pending
Merged
gbanasiak
added a commit
that referenced
this pull request
Dec 3, 2025
This is an empty commit which records missing backports from manual or squashed backports through "cherry picked from" metadata. CI determines Elasticsearch build arguments #925 (#926) (cherry picked from commit 8c33ff5) Exclude some challenges when testing with ES release builds #922 (#919) (cherry picked from commit f38f8fc) Reduce filtering scope in CI workflow #908 (#919) (cherry picked from commit 8e571a5) Address pytest deprecations #911 (#919) (cherry picked from commit fa81c5e) Solves problems with expensive inlinestats benchmarks #896 (#919) (cherry picked from commit 8209244) Adds better challenges for comparing inlinestats #873 (#919) (cherry picked from commit c41a950)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using inlinestats queries with the limit after the index querying:
and we were observing weird results in the benchmarks, possibly due to this issue, where a query with just one inline stats would be faster than the one above:
I arrived at the conclusion those are not a good benchmark, because the time used to fetch the rows from disk is dominating the query time.
This PR changes all of those queries to have the limit at the end:
This PR also changes
inlinestatsbyinline stats, given the first one seems deprecated when using the_queryapi: