-
Notifications
You must be signed in to change notification settings - Fork 218
Add new challenge to elastic/logs to benchmark the INSIST_🐔 esql command #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ed2a087
Add mapping track parameter
martijnvg b1d0272
INSIST_🐔
martijnvg f1a5f49
Tweak template
martijnvg f91ed4c
tweak queries in order to make it work for INSIST_🐔 and the non strea…
martijnvg 3e58f60
use constant keyword field as additional group field as workaround
martijnvg 05a43a3
fix typos
martijnvg 587dd53
iter
martijnvg bbaa759
Alter number of iterations for now because insist is currently very s…
martijnvg e177852
add new queries
martijnvg d35d120
oops
martijnvg ed1e36b
iter
martijnvg 7739140
added comments
martijnvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| {% import "rally.helpers" as rally %} | ||
| { | ||
| "name": "logging-insist-chicken", | ||
| "description": "INSIST_🐔 everything", | ||
| "schedule": [ | ||
| {% include "tasks/index-setup.json" %}, | ||
| { | ||
| "name": "bulk-index", | ||
| "operation": { | ||
| "operation-type": "raw-bulk", | ||
| "param-source": "processed-source", | ||
| "time-format": "milliseconds", | ||
| "profile": "fixed_interval", | ||
| "bulk-size": {{ p_bulk_size }}, | ||
| "detailed-results": true | ||
| }, | ||
| "clients": {{ p_bulk_indexing_clients }}{% if p_throttle_indexing %}, | ||
| "ignore-response-error-level": "{{error_level | default('non-fatal')}}", | ||
| "schedule": "timestamp-throttler", | ||
| "max-delay-secs": 1 | ||
| {% endif %} | ||
| }, | ||
| { | ||
| "name": "refresh-after-index", | ||
| "index": "logs-*", | ||
| "operation": "refresh" | ||
| }, | ||
| { | ||
| "name": "wait-until-index-merges-fininshes", | ||
| "operation": { | ||
| "operation-type": "index-stats", | ||
| "index": "logs-*", | ||
| "condition": { | ||
| "path": "_all.total.merges.current", | ||
| "expected-value": 0 | ||
| }, | ||
| "retry-until-success": true, | ||
| "include-in-reporting": false | ||
| }, | ||
| "tags": ["wait"] | ||
| }, | ||
| { | ||
| "operation": "disable_query_cache", | ||
| "tags": ["esql", "settings"] | ||
| }, | ||
| { | ||
| "operation": "limit_500", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(20) }}, | ||
| "iterations": {{ iterations | default(100) }}, | ||
| "tags": ["esql"] | ||
| }, | ||
| { | ||
| "operation": "chicken_1", | ||
| "clients": {{ p_search_clients }}, | ||
| {# TODO: restore iterations / warmup_iterations once insist_:chicken: has acceptable performance #} | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, | ||
| "tags": ["esql", "insist"] | ||
| }, | ||
| { | ||
| "operation": "chicken_2", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, | ||
| "tags": ["esql", "insist"] | ||
| }, | ||
| { | ||
| "operation": "chicken_3", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, | ||
| "tags": ["esql", "insist"] | ||
| }, | ||
| { | ||
| "operation": "chicken_3_with_where", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, | ||
| "tags": ["esql", "insist"] | ||
| }, | ||
| { | ||
| "operation": "chicken_4", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, | ||
| "tags": ["esql", "insist"] | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "name": "limit_500", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | LIMIT 500" | ||
| }, | ||
| {# TODO: All COALESCE usages can be removed once https://github.com/elastic/elasticsearch/issues/130220 is fixed #} | ||
| { | ||
| "name": "chicken_1", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 agent.id | EVAL col0 = COALESCE(agent.id, \"\") | WHERE MATCH(message, \"204.188.85.203\") and col0 == \"703ef3bd-dc06-4c6c-a621-13c89245e6b0\"" | ||
| }, | ||
| { | ||
| "name": "chicken_2", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 kubernetes.container.image | EVAL col0 = COALESCE(kubernetes.container.image, \"\") | WHERE col0 != \"\" | STATS col1 = COUNT() BY col0,data_stream.dataset" | ||
| }, | ||
| { | ||
| "name": "chicken_3", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 agent.id | STATS c=count() BY agent.id, data_stream.dataset | SORT c DESC" | ||
| }, | ||
| { | ||
| "name": "chicken_3_with_where", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 agent.id | EVAL end_time = DATE_PARSE(\"yyyy-MM-dd'T'HH:mm:ss.SSS'Z'\",\"{{ bulk_end_date }}\") | WHERE @timestamp >= end_time - 1 hour | STATS c=count() BY agent.id, data_stream.dataset | SORT c DESC" | ||
| }, | ||
| { | ||
| "name": "chicken_4", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 agent.hostname | EVAL col0 = COALESCE(agent.hostname, \"\") | WHERE col0 == \"elasticsearch-ci-immutable-centos-7-1599241536066250344\"" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "name": "logs-dynamic-false", | ||
| "index_template": { | ||
| "index_patterns": [ | ||
| "logs-*-*" | ||
| ], | ||
| "template": { | ||
| "settings": {}, | ||
| "mappings": { | ||
| "dynamic": false, | ||
| "properties": { | ||
| "@timestamp": { | ||
| "type": "date" | ||
| }, | ||
| "message": { | ||
| "type": "match_only_text" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "composed_of": [ | ||
| "logs@settings", | ||
| "logs@mappings", | ||
| "track-custom-shared-settings", | ||
| "track-data-stream-lifecycle", | ||
| "track-shared-logsdb-mode" | ||
| ], | ||
| "priority": 200, | ||
| "data_stream": { | ||
| "hidden": false, | ||
| "allow_custom_routing": false | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowered default
iterationsandwarmup_iterationssignificantly, given that insist command is very slow, otherwise it takes multiple days to complete the benchmark.This will be restored when performance for insist command improves.