Add new challenge to elastic/logs to benchmark the INSIST_🐔 esql command#801
Merged
martijnvg merged 12 commits intoelastic:masterfrom Jul 7, 2025
Merged
Add new challenge to elastic/logs to benchmark the INSIST_🐔 esql command#801martijnvg merged 12 commits intoelastic:masterfrom
martijnvg merged 12 commits intoelastic:masterfrom
Conversation
This controls whether all fields are mapped or whether almost all fields are unmapped.
martijnvg
changed the title
Member
Author
|
I did initial run of this new challenge: Indexing throughput looks reasonable, but the |
Member
Author
|
Did another run with latest version (this time using 1 node and no replicas, previous was with 3 nodes and 1 replica): |
martijnvg
changed the title
martijnvg
commented
Jul 7, 2025
| "operation": "chicken_1", | ||
| "clients": {{ p_search_clients }}, | ||
| "warmup-iterations": {{ warmup_iterations | default(3) }}, | ||
| "iterations": {{ iterations | default(5) }}, |
Member
Author
There was a problem hiding this comment.
lowered default iterations and warmup_iterations significantly, given that insist command is very slow, otherwise it takes multiple days to complete the benchmark.
This will be restored when performance for insist command improves.
Member
Author
|
Note that previous runs ran with mapped variant, all fields were mapped. Running with unmapped, the insist command is many orders of magnitude slower. |
flash1293
reviewed
Jul 7, 2025
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Left some smaller questions, but not blocking
| { | ||
| "name": "chicken_4", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 agent.hostname | EVAL col0 = COALESCE(agent.hostname, \"elasticsearch-ci-immutable-centos-7-1599241536066250344\") | WHERE col0 == \"elasticsearch-ci-immutable-centos-7-1599241536066250344\"" |
Contributor
There was a problem hiding this comment.
Why are you coalescing with \"elasticsearch-ci-immutable-centos-7-1599241536066250344\" here - shouldn't it be FROM logs-* | INSIST_🐔 agent.hostname | EVAL col0 = COALESCE(agent.hostname, \"\") | WHERE col0 == \"elasticsearch-ci-immutable-centos-7-1599241536066250344\" ?
Member
Author
There was a problem hiding this comment.
Not sure, I think this what I copied from: https://github.com/elastic/streams-program/discussions/320#discussioncomment-13583964
In anyway, I will update this.
| { | ||
| "name": "chicken_2", | ||
| "operation-type": "esql", | ||
| "query": "FROM logs-* | INSIST_🐔 event.dataset,kubernetes.container.image | EVAL col0 = COALESCE(kubernetes.container.image, \"\") | WHERE col0 != \"\" | STATS col1 = COUNT() BY col0,data_stream.dataset" |
Contributor
There was a problem hiding this comment.
why do we insist event.dataset here?
Member
Author
There was a problem hiding this comment.
Good point. That got in by mistake. I will update.
flash1293
approved these changes
Jul 7, 2025
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
LGTM. Maybe we should leave a note somewhere that the coalesce calls can be removed once elastic/elasticsearch#130220 is fixed. Otherwise people will wonder where it comes from
Member
Author
|
Successful run based on most recent commit: This ran with one node and can be compared with: #801 (comment) |
4 tasks
esbenchmachine
added
the
backport pending
Collaborator
|
@martijnvg
Backporting entails:
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add
mappingtrack parameter which controls whether all fields are mapped or whether almost all fields are unmapped. This allows for benchmarking elastic/logs in an unmapped context with experimental INSIST_🐔 esql command.