Skip to content

Define version pattern in a single place #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ycombinator merged 4 commits into from
Mar 23, 2021
Merged

Define version pattern in a single place #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
586cda6
Define version in a single place
ycombinator Mar 23, 2021
bce256a
Sharing the definition of a version
ycombinator Mar 23, 2021
8337e2a
Adding more examples
ycombinator Mar 23, 2021
3ed26f4
Updating specs
ycombinator Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/go/internal/spec/statik.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions versions/1/changelog.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ spec:
properties:
version:
description: Package version.
type: string
pattern: '^[0-9]+\.[0-9]+\.[0-9]+$'
examples:
- "1.0.4"
$ref: "./manifest.spec.yml#/definitions/version"
changes:
description: List of changes in package version.
type: array
Expand Down
17 changes: 9 additions & 8 deletions versions/1/manifest.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,17 @@ spec:
required:
- src
- title
properties:
format_version:
description: The version of the package specification format used by this package.
version:
type: string
pattern: '^([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*))?(?:\+[0-9A-Za-z-]+)?$'
examples:
- "1.0.0"
- "1.0.0"
- "1.0.0-SNAPSHOT"
- "1.0.0-dev.1"
properties:
format_version:
description: The version of the package specification format used by this package.
$ref: "#/definitions/version"
name:
description: The name of the package.
type: string
Expand All @@ -123,10 +127,7 @@ spec:
- Apache Integration
version:
description: The version of the package.
type: string
pattern: '^([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*))?(?:\+[0-9A-Za-z-]+)?$'
examples:
- "0.1.0"
$ref: "#/definitions/version"
license:
description: The license under which the package is being released.
type: string
Expand Down