Define version pattern in a single place#153
Merged
ycombinator merged 4 commits intoelastic:masterfrom Mar 23, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR defines the pattern for a version in a single place and references it from multiple version properties.
Why is it important?
So the pattern for a version doesn't need to be duplicated in multiple places, introducing a potential for drift and inconsistencies.
Checklist
I have added test packages toExisting packages have versions in them already.test/packagesthat prove my change is effective.I have added an entry inNo changelog entry as this is a refactoring, not a user-facing change.versions/N/changelog.yml.