Skip to content

Add deployer setting to system test configuration#1104

Merged
mrodm merged 5 commits intoelastic:mainfrom
mrodm:add_deployer_to_system_tests
Mar 5, 2026
Merged

Add deployer setting to system test configuration#1104
mrodm merged 5 commits intoelastic:mainfrom
mrodm:add_deployer_to_system_tests

Conversation

@mrodm
Copy link
Copy Markdown
Contributor

@mrodm mrodm commented Mar 5, 2026

What does this PR do?

Add the validation of the deployer setting into the system test configuration file spec.

It is based on the changes introduced in #1099

Why is it important?

It ensures via spec that the values for this setting are the expected ones in the system test configuration files.

Checklist

Related issues

@mrodm mrodm self-assigned this Mar 5, 2026
@mrodm mrodm force-pushed the add_deployer_to_system_tests branch from ad53533 to 3673483 Compare March 5, 2026 11:30
@mrodm
Copy link
Copy Markdown
Contributor Author

mrodm commented Mar 5, 2026

/test

@mrodm mrodm marked this pull request as ready for review March 5, 2026 12:27
@mrodm mrodm requested a review from a team as a code owner March 5, 2026 12:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46e9bc49-a842-4dff-9fb5-f6018d3433e4

📥 Commits

Reviewing files that changed from the base of the PR and between 9267a67 and c7be809.

📒 Files selected for processing (6)
  • code/go/pkg/validator/validator_test.go
  • spec/changelog.yml
  • spec/integration/data_stream/_dev/test/config.spec.yml
  • spec/integration/data_stream/_dev/test/system/config.spec.yml
  • test/packages/bad_deployer_system_test/docs/README.md
  • test/packages/good_v3/data_stream/foo/_dev/test/system/test-default-config.yml
✅ Files skipped from review due to trivial changes (1)
  • test/packages/bad_deployer_system_test/docs/README.md
🚧 Files skipped from review as they are similar to previous changes (4)
  • spec/integration/data_stream/_dev/test/config.spec.yml
  • code/go/pkg/validator/validator_test.go
  • test/packages/good_v3/data_stream/foo/_dev/test/system/test-default-config.yml
  • spec/integration/data_stream/_dev/test/system/config.spec.yml

📝 Walkthrough

Walkthrough

The PR introduces a deployer option to the system test configuration schema, allowing specification of which service deployer (docker, tf, or k8s) to use. It adds a deployer property definition to the data stream test config spec, consolidates deployer schema references across benchmark and system configuration files to use the external definition, and creates a comprehensive test package to validate the constraint. An existing test package is updated to include the new deployer property, and a new validator test case is added to ensure invalid deployer values are rejected.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

jsoriano
jsoriano previously approved these changes Mar 5, 2026
@@ -0,0 +1,82 @@
<!-- NOTICE: Do not edit this file manually.-->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Create a simple README that describes the purpose of the test package, and remove the template.

@mrodm mrodm enabled auto-merge (squash) March 5, 2026 17:17
@mrodm mrodm merged commit 3e48996 into elastic:main Mar 5, 2026
4 checks passed
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mrodm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants