Add new property deployer for system benchmarks#1099
Merged
mrodm merged 3 commits intoelastic:mainfrom Mar 2, 2026
Merged
Conversation
kcreddy
added
enhancement
Contributor
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
💚 Build Succeeded
History
cc @kcreddy |
Contributor
Author
|
@teresaromero, could you please merge this? I don't have privileges to merge. |
Contributor
i would like @mrodm to take a final look before merging |
mrodm
approved these changes
Mar 2, 2026
Contributor
Author
|
@mrodm, thanks for the approval. Please feel free to merge, as I don't have merge access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add deployer option to system benchmark configuration
Add support for the
deployerproperty in system benchmark configurationfiles, allowing users to specify which service deployer (docker, tf, or k8s) to
use for benchmarks. This aligns system benchmarks with the existing system
test configuration capabilities.
Includes validation test packages for both valid and invalid deployer
configurations.
Why is it important?
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues