Adjust property names for package dependencies to original proposal#1102
Adjust property names for package dependencies to original proposal#1102jsoriano merged 4 commits intoelastic:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughParsing of manifest requirements was changed from the ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@code/go/internal/validator/semantic/validate_test_package_requirements.go`:
- Around line 245-251: In validateTestRequirementSource, reject absolute source
paths instead of relying on filepath.Join (which skips the config dir for
absolute inputs); add an explicit check using filepath.IsAbs(source) and return
a specerrors.NewStructuredErrorf indicating the source must be a relative path
before computing targetPath and calling os.Stat. Ensure you reference
validateTestRequirementSource and use filepath.IsAbs(source) to guard against
absolute paths.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
code/go/internal/validator/semantic/validate_test_package_requirements.gocode/go/internal/validator/semantic/validate_test_package_requirements_test.gotest/packages/good_requires/_dev/test/config.yml
code/go/internal/validator/semantic/validate_test_package_requirements.go
Show resolved
Hide resolved
💚 Build Succeeded
History
cc @jsoriano |
test/packages/good_requires/data_stream/logs/_dev/test/system/test-default-config.yml
Show resolved
Hide resolved
had some thoughts after approval, left couple comments
What does this PR do?
When declaring package dependencies, use "package" in all cases for the package name, so all declarations are consistent. This is also coherent with the original proposal.
Also, add "source" in test dependencies, as a way to indicate the source of the package to install or reuse, instead of retrieving it form the package registry. This is useful for development of packages that live in the same repository.
Thanks @teresaromero for reporting!
Why is it important?
For consistency and coherence with the original proposal.
Checklist
test/packagesthat prove my change is effective.I have added an entry inNo need as this modifies a feature not released yet.spec/changelog.yml.Related issues