Skip to content

Revert use of WaitGroup.Go #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsoriano merged 1 commit into from
Feb 12, 2026
Merged

Revert use of WaitGroup.Go #1567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions workers/taskpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ func NewTaskPool(size int) *taskPool {
// Do runs the task in a goroutine, ensuring no more tasks are running than the size of the pool.
func (p *taskPool) Do(task func() error) {
p.pool <- struct{}{}
p.wg.Go(func() {
p.wg.Add(1)
go func() {
defer p.wg.Done()
defer func() { <-p.pool }()

err := task()
p.recordError(err)
})
}()
}

func (p *taskPool) recordError(err error) {
Expand Down