Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
💚 Build Succeeded
cc @jsoriano |
mrodm
approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
👍
in the future we should probably keep both versions aligned, or add a CI job that tests with the matrix of versions supported.
Agreed!
Could you create an issue for that?
Including that testing will help us validating that our code base supports all the Golang versions according to the go.mod (at least the latest versions of each minor).
Member
Author
Issue created: #1568 |
fred-maussion
pushed a commit
to fred-maussion/package-registry
that referenced
this pull request
Feb 12, 2026
It is not available in Go 1.24, the version used in go.mod files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync.WaitGroup.Gowas introduced in Go 1.25, but the projectgo.modfiles indicatego 1.24. This is not failing in CI because.go-versionhas a 1.25 version.By now I would revert the use of this new method, but in the future we should probably keep both versions aligned, or add a CI job that tests with the matrix of versions supported.
Alternatively, as 1.26 has been just released, we could also update everything to 1.25.