Skip to content

Fix creation of zip packages in Windows #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsoriano merged 2 commits into from
Nov 26, 2025
Merged

Fix creation of zip packages in Windows #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e3536
Zip package should actually have only forward slashes
jsoriano Nov 25, 2025
b27b741
Try to fix
jsoriano Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archiver/archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func buildArchiveHeader(info os.FileInfo, relativePath string) (*zip.FileHeader,
}

header.Method = zip.Deflate
header.Name = relativePath
header.Name = filepath.ToSlash(relativePath)
if info.IsDir() && !strings.HasSuffix(header.Name, "/") {
header.Name = header.Name + "/"
}
Expand Down
5 changes: 1 addition & 4 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,10 +689,7 @@ func listArchivedFiles(t *testing.T, body []byte) []byte {
var listing bytes.Buffer

for _, f := range zipReader.File {
// f.Name is populated from the zip file directly and is not validated for correctness.
// Using filepath.ToSlash(f.Name) ensures that the file name has the expected format
// regardless of the OS.
listing.WriteString(fmt.Sprintf("%d %s\n", f.UncompressedSize64, filepath.ToSlash(f.Name)))
listing.WriteString(fmt.Sprintf("%d %s\n", f.UncompressedSize64, f.Name))
}
return listing.Bytes()
}
Expand Down