Skip to content

Fix creation of zip packages in Windows#1490

Merged
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:archiver-windows
Nov 26, 2025
Merged

Fix creation of zip packages in Windows#1490
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:archiver-windows

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Nov 25, 2025

Package Registry was using the OS-native relative paths directly when building zip packages. On windows this was using back slashes, but names in zip headers are expected to use forward slashes.

Tests were passing only because the paths were converted when reading the zip.

@jsoriano jsoriano self-assigned this Nov 25, 2025
@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano marked this pull request as ready for review November 25, 2025 17:41
@jsoriano jsoriano requested a review from a team as a code owner November 25, 2025 17:41
@jsoriano jsoriano enabled auto-merge (squash) November 25, 2025 17:46
@jsoriano jsoriano merged commit 8e53eb0 into elastic:main Nov 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants