-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove references to document_type in the docs #8603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pushed additional changes for issues identified in #8606. Updated the examples because some changes have happened to the event structure. Also added an updated screen capture for the tutorial because it was easy for me to grab the screen while I was updating the example. |
3ecebfc
to
ac419f8
Compare
"host" => "My-MacBook-Pro.local", | ||
"prospector" => { | ||
"type" => "log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton my point here was, didn't Beats, in general, start defaulting type => doc instead of log in 6.0? elastic/beats#3757
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless the prospector "type" is different from the default "doc type". You may be understand it better than I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the difference. If you look at the full output, you'll see that the _type
field is set to doc
as expected. The type
filed on line 174 is the prospector type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
@dedemorton LGTM, thank you. |
We good to merge this one? |
Doc changes related to logstash-plugins/logstash-output-elasticsearch#691
Removes
document_type
from LS configuration examples in the static docs. Thedocument_type
is now set automatically todoc
, which is consistent with what the Beats dashboards expect.I've searched the static docs for
document_type
and_type
and have found no other instances, so I'm assuming there is no additional impact to the static docs unless I'm overlooking something.I'll open separate PRs to address any references to
document_type
in the plugin docs.