Skip to content

Remove references to document_type in the docs #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dedemorton
Copy link
Contributor

Doc changes related to logstash-plugins/logstash-output-elasticsearch#691

Removes document_type from LS configuration examples in the static docs. The document_type is now set automatically to doc, which is consistent with what the Beats dashboards expect.

I've searched the static docs for document_type and _type and have found no other instances, so I'm assuming there is no additional impact to the static docs unless I'm overlooking something.

I'll open separate PRs to address any references to document_type in the plugin docs.

@dedemorton
Copy link
Contributor Author

Pushed additional changes for issues identified in #8606. Updated the examples because some changes have happened to the event structure.

Also added an updated screen capture for the tutorial because it was easy for me to grab the screen while I was updating the example.

"host" => "My-MacBook-Pro.local",
"prospector" => {
"type" => "log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton my point here was, didn't Beats, in general, start defaulting type => doc instead of log in 6.0? elastic/beats#3757

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the prospector "type" is different from the default "doc type". You may be understand it better than I do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the difference. If you look at the full output, you'll see that the _type field is set to doc as expected. The type filed on line 174 is the prospector type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@acchen97
Copy link
Contributor

@dedemorton LGTM, thank you.

@acchen97
Copy link
Contributor

We good to merge this one?

@elasticsearch-bot
Copy link

DeDe Morton merged this into the following branches!

Branch Commits
master 78ca2b1, 1213c56, 88563c8
6.0 7e19d99, fba774a, a9da597
6.x 16b49ad, aca9b0c, 8e3e72a

elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
elasticsearch-bot pushed a commit that referenced this pull request Nov 14, 2017
insukcho pushed a commit to insukcho/logstash that referenced this pull request Feb 1, 2018
insukcho pushed a commit to insukcho/logstash that referenced this pull request Feb 1, 2018
insukcho pushed a commit to insukcho/logstash that referenced this pull request Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants