elasticsearch: set _type=doc #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link to the elasticsearch / pr of the change to provide some more feedback on why this change is needed? This must be added to the CHANGELOG.asciidoc as this is a breaking change in case someone was using _type before. This becomes especially obvious for people using filebeat where |
The `_type` field is deprecated per elastic/elasticsearch#15613
|
Can you rebase and squash and update the commit and PR message? This makes it easier for people that stumble over the PR later to find the right info. |
ruflin
approved these changes
Mar 17, 2017
|
I updated the first comment to the PR, I have a single commit I don't think I need squashing. Thanks! |
|
@7AC I see 2 commits in this PR? One is a merge commit. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
May 3, 2017
The `_type` field is deprecated per elastic/elasticsearch#15613 (cherry picked from commit bec7603)
monicasarbu
pushed a commit
that referenced
this pull request
May 3, 2017
The `_type` field is deprecated per elastic/elasticsearch#15613 (cherry picked from commit bec7603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use special
_type=docinstead of custom ones. The_typefield is deprecated per elastic/elasticsearch#15613.