Skip to content

Conversation

@andsel
Copy link
Contributor

@andsel andsel commented Aug 22, 2025

Release notes

[rn:skip]

Why is it important/What is the impact to the user?

Update the list of logstash settings with the new pipeline.batch.metrics.sampling_mode to control the batch size ones.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

@andsel andsel self-assigned this Aug 22, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

🔍 Preview links for changed docs

@andsel andsel force-pushed the docs/describe_batch_metrics_average_lifetime branch 4 times, most recently from 6504178 to 08a70a6 Compare September 23, 2025 16:30
@andsel andsel force-pushed the docs/describe_batch_metrics_average_lifetime branch from 08a70a6 to 1917213 Compare September 23, 2025 16:31
@andsel andsel force-pushed the docs/describe_batch_metrics_average_lifetime branch from 0c03045 to d8dbe91 Compare September 23, 2025 16:35
@andsel andsel marked this pull request as ready for review September 24, 2025 06:55
@andsel andsel added the docs label Sep 24, 2025
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small rewording suggestions

@andsel andsel changed the title Documentation for batch's average event count and byte size metrics. Documentation for batch's event metrics (current and average) Sep 26, 2025
@andsel andsel requested a review from robbavey September 26, 2025 09:45
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark the applies_to as preview to denote technical preview instead of ga

@andsel andsel requested a review from robbavey September 29, 2025 07:57
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andsel andsel requested a review from robbavey September 30, 2025 06:34
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel
Copy link
Contributor Author

andsel commented Sep 30, 2025

Thanks @robbavey for your suggestions!

@andsel andsel merged commit 0f8c7ba into elastic:main Sep 30, 2025
10 checks passed
v1v pushed a commit that referenced this pull request Oct 21, 2025
Update the list of logstash settings with the new pipeline.batch.metrics.sampling_mode to control the batch size ones.

Co-authored-by: Rob Bavey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document current value of batch's byte size and event count average metrics Document feature flag and byte size and event count average metrics

2 participants