-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Documentation for batch's event metrics (current and average) #18017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for batch's event metrics (current and average) #18017
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
🔍 Preview links for changed docs |
…d in the metrics API response
6504178 to
08a70a6
Compare
08a70a6 to
1917213
Compare
0c03045 to
d8dbe91
Compare
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small rewording suggestions
Rewording and various fixes. Co-authored-by: Rob Bavey <[email protected]>
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark the applies_to as preview to denote technical preview instead of ga
Co-authored-by: Rob Bavey <[email protected]>
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting changes - check preview for current value (https://docs-v3-preview.elastic.dev/elastic/logstash/pull/18017/reference/logstash-settings-file)
Co-authored-by: Rob Bavey <[email protected]>
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @robbavey for your suggestions! |
Update the list of logstash settings with the new pipeline.batch.metrics.sampling_mode to control the batch size ones. Co-authored-by: Rob Bavey <[email protected]>
Release notes
[rn:skip]
Why is it important/What is the impact to the user?
Update the list of logstash settings with the new
pipeline.batch.metrics.sampling_modeto control the batch size ones.Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues