Skip to content

[ML] Add tooltips for actual and typical in anomalies table #97549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcawl merged 2 commits into from
Apr 20, 2021
Merged

[ML] Add tooltips for actual and typical in anomalies table #97549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e535ca8
[ML] Add tooltips for actual and typical in anomalies table
lcawl Apr 19, 2021
3907ff4
Addresses feedback
lcawl Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ describe('AnomaliesTable', () => {
name: 'influenced by',
}),
expect.objectContaining({
name: 'actual',
field: 'actualSort',
}),
expect.objectContaining({
name: 'typical',
field: 'typicalSort',
}),
expect.objectContaining({
name: 'description',
Expand Down
36 changes: 29 additions & 7 deletions x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { EuiButtonIcon, EuiLink, EuiScreenReaderOnly } from '@elastic/eui';
import { EuiButtonIcon, EuiLink, EuiScreenReaderOnly, EuiToolTip, EuiIcon } from '@elastic/eui';

import React from 'react';
import { get } from 'lodash';
Expand Down Expand Up @@ -178,9 +178,20 @@ export function getColumns(
columns.push({
field: 'actualSort',
'data-test-subj': 'mlAnomaliesListColumnActual',
name: i18n.translate('xpack.ml.anomaliesTable.actualSortColumnName', {
defaultMessage: 'actual',
}),
name: (
<EuiToolTip
content={i18n.translate('xpack.ml.overview.anomalyDetection.tableActualTooltip', {
defaultMessage: 'The actual values in the anomaly record results.',
})}
>
<span>
{i18n.translate('xpack.ml.anomaliesTable.actualSortColumnName', {
defaultMessage: 'Actual',
})}
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</span>
</EuiToolTip>
),
render: (actual, item) => {
const fieldFormat = mlFieldFormatService.getFieldFormat(
item.jobId,
Expand All @@ -196,9 +207,20 @@ export function getColumns(
columns.push({
field: 'typicalSort',
'data-test-subj': 'mlAnomaliesListColumnTypical',
name: i18n.translate('xpack.ml.anomaliesTable.typicalSortColumnName', {
defaultMessage: 'typical',
}),
name: (
<EuiToolTip
content={i18n.translate('xpack.ml.overview.anomalyDetection.tableTypicalTooltip', {
defaultMessage: 'The typical values in the anomaly record results.',
})}
>
<span>
{i18n.translate('xpack.ml.anomaliesTable.typicalSortColumnName', {
defaultMessage: 'Typical',
})}
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</span>
</EuiToolTip>
),
render: (typical, item) => {
const fieldFormat = mlFieldFormatService.getFieldFormat(
item.jobId,
Expand Down